-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stacked config not used on commands #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one question.
Another question I have is to please put an example of how it works to make it easier to review.
@@ -41,13 +41,22 @@ class DeleteViewCommand extends Command with ProjectStructureValidator { | |||
help: 'The length of the line that is used for formatting', | |||
valueHelp: '80', | |||
); | |||
|
|||
argParser.addOption( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ferrarafer does adding this here mean we have to pass the config path every time we run a command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, just when you want to do something different as the project configuration in the root of the project, stacked.json
.
config-path-demo.mp4
Good suggestion @FilledStacks ! All the commands except Examples (current user location on terminal: $> stacked create view settings Will loads configuration from $> stacked create view settings --config-path=/Users/filledstacks/Desktop/dane.config.json Will loads configuration from The create app command works different for obvious reason, as project does not exists there is no configuration inside to look for. When you create a project with stacked_cli you have 3 options. Examples (current user location on terminal: $> stacked create app my_app
$> stacked create app my_app --config-path=/Users/filledstacks/Desktop/dane.config.json
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the detailed comments
## [1.8.3](v1.8.2...v1.8.3) (2023-05-25) ### Bug Fixes * stacked config not used on commands ([#23](#23)) ([083aa0b](083aa0b))
🎉 This PR is included in version 1.8.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
--config-path
option to all commands where configuration file is needed_clean
method before deletionFixes Stacked-Org/stacked#912
Fixes Stacked-Org/stacked#960